Repository navigation
[CP Staging] Fix saved search names - #49235
Conversation
|
@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
[CP Staging] Fix saved search names (cherry picked from commit 14b5ccc) (CP triggered by luacmartins)
|
🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.0.35-3 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Deployed to production by https://github.com/grgia in version: 9.0.35-7 🚀
|
| }, | ||
| rightComponent: ( | ||
| <ThreeDotsMenu | ||
| menuItems={getOverflowMenu(item.name, Number(key), item.query)} |
There was a problem hiding this comment.
FYI, This PR missed to use title instead of item.name here and caused this bug: #49739, More info in this proposal: #49739 (comment)
Details
Makes sure that the default saved search names match the custom header, e.g. they don't display an accountID, cardID or reportID, but the actual user display name, card name, report name, etc
Fixed Issues
$ #49216
Tests
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop